This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
RE: [PATCH] Fix for ldm/stm instructions in H8S
- From: "Asgari J. Jinia" <AsgariJ at KPITCummins dot com>
- To: "Richard Sandiford" <rsandifo at redhat dot com>,"Nick Clifton" <nickc at redhat dot com>
- Cc: <kazu at cs dot umass dot edu>,<binutils at sources dot redhat dot com>
- Date: Wed, 26 Nov 2003 16:42:43 +0530
- Subject: RE: [PATCH] Fix for ldm/stm instructions in H8S
Hi Nick,
I think t01_mov.s is compiled for H8SX target so register pair (er4-er7) is valid as mentioned in
H8SX family programming manual. So I think those lines from t01_mov.s and t01_mov.exp are necessary.
Regards,
Asgari Jinia
-----Original Message-----
From: Richard Sandiford [mailto:rsandifo@redhat.com]
Sent: Wednesday, November 26, 2003 4:27 PM
To: Nick Clifton
Cc: Asgari J. Jinia; kazu@cs.umass.edu; binutils@sources.redhat.com
Subject: Re: [PATCH] Fix for ldm/stm instructions in H8S
Nick Clifton <nickc@redhat.com> writes:
> Hi Asgari,
> > I have modified patch for H8S and H8SX targets. Also I have created
> > patches for multiples.s and h8300.exp in gas/h8300 testsuite. This
> > was tested with binutils-031111 testsuite and found okay.
>
> Thanks very much - this patch is much better. There was one small
> omission - the h8300 testcase t01_mov.s had a couple of illegal
> register pairings in it, which lead to an extra 78 unexpected failures
> when the gas testsuite was run for the h8300-elf toolchain.
>
> I have applied your patch together with a fix to t01_mov.s and
> t01_mov.exp so that there are no new testsuite failures.
Hmm, I see the changes you made are the ones below. Are you sure
that's right? My understanding was that r4-r7 was a valid sequence
on the H8SX. I think the tech note only applies to the H8S.
Richard
Index: t01_mov.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/h8300/t01_mov.s,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- t01_mov.s 5 Jun 2003 18:52:00 -0000 1.1
+++ t01_mov.s 25 Nov 2003 16:13:36 -0000 1.2
@@ -1067,7 +1067,7 @@
ldm @sp+,(er1-er4) ;01306d74
ldm @sp+,(er2-er5) ;01306d75
ldm @sp+,(er3-er6) ;01306d76
- ldm @sp+,(er4-er7) ;01306d77
+ ldm @sp+,(er5-er7) ;01206d77
stm (er0-er1),@-sp ;01106df0
stm (er1-er2),@-sp ;01106df1
@@ -1088,7 +1088,7 @@
stm (er1-er4),@-sp ;01306df1
stm (er2-er5),@-sp ;01306df2
stm (er3-er6),@-sp ;01306df3
- stm (er4-er7),@-sp ;01306df4
+ stm (er5-er7),@-sp ;01206df5
eepmov.b ;7b5c598f