This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix demangler in symbol versioning


"H. J. Lu" <hjl@lucon.org> writes:

> -      cxx_sym = cplus_demangle (sym, /* DMGL_NO_TPARAMS */ 0);
> +      cxx_sym = cplus_demangle (sym, (DMGL_PARAMS
> +				      | DMGL_ANSI
> +				      | DMGL_VERBOSE));

I doubt you need DMGL_VERBOSE here, and I would recommend against it.

>    if (head->mask & BFD_ELF_VERSION_JAVA_TYPE)
>      {
> -      java_sym = cplus_demangle (sym, DMGL_JAVA);
> +      java_sym = java_demangle_v3 (sym);
>        if (!java_sym)
>  	java_sym = sym;
>      }

I'm puzzled as to how this could ever have worked.  I think you can
only demangle Java via cplus_demangle() if you call
cplus_demangle_set_style().  But perhaps I am missing something.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]