Re: PATCH: Fix demangler in symbol versioning

[Ian Lance Taylor <ian at wasabisystems dot com>]

Daniel Jacobowitz <drow@mvista.com> writes:

> > >    if (head->mask & BFD_ELF_VERSION_JAVA_TYPE)
> > >      {
> > > -      java_sym = cplus_demangle (sym, DMGL_JAVA);
> > > +      java_sym = java_demangle_v3 (sym);
> > >        if (!java_sym)
> > >  	java_sym = sym;
> > >      }
> > 
> > I'm puzzled as to how this could ever have worked.  I think you can
> > only demangle Java via cplus_demangle() if you call
> > cplus_demangle_set_style().  But perhaps I am missing something.
> 
> I am fairly certain it used to work.  A change here might explain
> problems Ulrich Weigand saw in the GDB Java testsuite...

Ah, you're right, now I see how it works.

H.J., I don't see why this part of the patch is needed.  When
cplus_demangle() is called with DMGL_JAVA, it simply turns around and
calls java_demangle_v3() anyhow.

Ian