This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Simplify mips16 conversion to even address

From: Richard Sandiford <rsandifo at redhat dot com>
To: fnf at redhat dot com
Cc: binutils at sources dot redhat dot com
Date: Sat, 06 Mar 2004 20:35:58 +0000
Subject: Re: [PATCH] Simplify mips16 conversion to even address
References: <200403042153.58621.fnf@ninemoons.com> <87u112xl4c.fsf@redhat.com><20040306134129.GC18129@bubble.modra.org>

Alan Modra <amodra@bigpond.net.au> writes:
> On Sat, Mar 06, 2004 at 11:36:51AM +0000, Richard Sandiford wrote:
>> Fred Fish <fnf@ninemoons.com> writes:
>> > +  if (sym->st_other == STO_MIPS16)
>> > +    sym->st_value &= ~1;
>> 
>> This isn't 64-bit clean, is it?
>
> No, it's OK.  `1' is an int.  ~1 is too, == -2.  -2 is sign extended
> when promoting to larger integer types.

Doh!  Yes of course, sorry for the noise...

Richard

References:
- [PATCH] Simplify mips16 conversion to even address
  - From: Fred Fish
- Re: [PATCH] Simplify mips16 conversion to even address
  - From: Richard Sandiford
- Re: [PATCH] Simplify mips16 conversion to even address
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]