This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[rfc] dw2gencfi.c vs DW_CFA_restore
- From: Richard Henderson <rth at twiddle dot net>
- To: binutils at gcc dot gnu dot org
- Date: Sat, 6 Mar 2004 23:16:12 -0800
- Subject: [rfc] dw2gencfi.c vs DW_CFA_restore
Thoughts?
r~
Index: dw2gencfi.c
===================================================================
RCS file: /cvs/src/src/gas/dw2gencfi.c,v
retrieving revision 1.15
diff -c -p -d -r1.15 dw2gencfi.c
*** dw2gencfi.c 29 Aug 2003 20:32:55 -0000 1.15
--- dw2gencfi.c 7 Mar 2004 07:14:26 -0000
*************** select_cie_for_fde (struct fde_entry *fd
*** 988,996 ****
--- 988,1005 ----
cie->return_column = fde->return_column;
cie->first = fde->data;
+ #if 0
+ /* It is wrong to automatically promote CFI insns into the CIE, as
+ what's present in the CIE affects the meaning of DW_CFA_restore.
+ Which raises the point -- if we want to meaningfully support
+ DW_CFA_restore at all, we need to be able to mark what belongs
+ in the CIE and what doesn't. */
for (i = cie->first; i ; i = i->next)
if (i->insn == DW_CFA_advance_loc)
break;
+ #else
+ i = cie->first;
+ #endif
cie->last = i;
*pfirst = i;