This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: warnings in libiberty/testsuite/test-demangle.c


Andreas Jaeger <aj@suse.de> writes:

> I just noticed the following warnings:
> ../../../libiberty/testsuite/test-demangle.c: In function `main':
> ../../../libiberty/testsuite/test-demangle.c:181: warning: implicit declaration
> unction `strcspn'
> ../../../libiberty/testsuite/test-demangle.c:184: warning: implicit declaration
> unction `strcmp'
> ../../../libiberty/testsuite/test-demangle.c:217: warning: implicit declaration
> unction `strspn'
> ../../../libiberty/testsuite/test-demangle.c:261: warning: implicit declaration
> unction `free'
> 
> Ok to commit the appended patch?

Sure, but the master repository for libiberty is gcc, so check it into
the gcc repository, not the src repository.

> Btw. there's also this warning which seems to be true:
> 
> /cvs/binutils-ln/libiberty/testsuite/test-demangle.c: In function `main':
> /cvs/binutils-ln/libiberty/testsuite/test-demangle.c:128: warning: `style' might be used uninitialized in this function

Yes, I suppose we should check that it is set around the option
processing loop.  A patch for that is OK to check in too.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]