This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
[PATCH-SH]:Generating proper relocations to link with Renesas SHC linker
- From: "Asgari J. Jinia" <AsgariJ at KPITCummins dot com>
- To: <binutils at sources dot redhat dot com>
- Date: Tue, 23 Mar 2004 18:04:04 +0530
- Subject: [PATCH-SH]:Generating proper relocations to link with Renesas SHC linker
Hi,
If GNU object file for SH target which contains static functions is linked
with other Renesas SHC objects by SHC linker, it does not call GNU
functions properly. It always calls the first static function when other
static functions are called. This is because GNU assembler does not emit
relocations with addend values in case of static functions.
Following patch emits addend value in relocations for static declarations so
that it will correctly link with Renesas linker.
Regards,
Asgari Jinia
KPIT Cummins
Testcase:
Following is simple test code.
Command Line: sh-elf-gcc test.c -c -mhitachi -o test.o
/* test.c */
static int foo( int a, int b, int c)
{
return a+b;
}
static int bar( int a, int b, int c)
{
return a+b;
}
int dummymain()
{
foo(1,2,3);
bar(1,2,3);
}
If test.o is linked with Renesas SHC linker and called "dummymain", "foo" is
called instead of "bar".
Patch:
gas/ChangeLog:
2004-03-23 Asgari Jinia <asgarij@kpitcummins.com>
* config/tc-sh.c (tc_gen_reloc): addend updated with fixp->fx_offset for
BFD_RELOC_32 and BFD_RELOC_32_GOTOFF type relocations.
==========================================================
--- gas/config/tc-sh.c.old Wed Dec 31 17:05:28 2003
+++ gas/config/tc-sh.c Tue Mar 23 17:26:03 2004
@@ -3957,7 +3957,7 @@ tc_gen_reloc (section, fixp)
else if (fixp->fx_pcrel)
rel->addend = fixp->fx_addnumber;
else if (r_type == BFD_RELOC_32 || r_type == BFD_RELOC_32_GOTOFF)
- rel->addend = fixp->fx_addnumber;
+ rel->addend = fixp->fx_offset;
else
rel->addend = 0;