This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] PE reloc overflow section header flags lossage
- From: Christopher Faylor <cgf at redhat dot com>
- To: binutils at sources dot redhat dot com
- Date: Wed, 24 Mar 2004 17:41:12 -0500
- Subject: Re: [PATCH] PE reloc overflow section header flags lossage
- References: <Pine.GSO.4.58.0403241517470.17486@thing1-200>
On Wed, Mar 24, 2004 at 03:51:27PM -0600, Brian Ford wrote:
>This was broken by 1.20 of peiXXigen.c.
>
>In that version, a local variable was used to add in the "must have" flags.
>Then, the local was output. Later (approximately line 1047), if the
>number of relocs overflowed, the pre "must have" flags or'ed in the
>overflow flag and were re-output.
>
>This patch just eliminates the local since it was not much of an
>optimization anyway.
>
>2004-03-24 Brian Ford <ford@vss.fsi.com>
>
> * peiXXigen.c (_bfd_XXi_swap_scnhdr_out): Correct section flags
> lossage on reloc overflow.
> (_bfd_XXi_swap_sym_in): Remove redundant section flags
> assignment.
It probably goes without saying but it looks like Nick was one of the
co-authors of the change you're referring to, so he'll probably need to
confirm or deny that this patch should go in.
cgf