This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: nop in load-delay-slot (on MIPS o32 PIC code)
Atsushi Nemoto wrote:
[snip]
> 2004-04-22 Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> * config/tc-mips.c (load_delay_nop): New function.
> (load_address, macro): Use load_delay_nop() to build a nop
> which can be omitted with gpr_interlocks.
>
> And for gas/testsuite.
>
> 2004-04-22 Atsushi Nemoto <anemo@mba.ocn.ne.jp>
>
> * gas/mips/lb-xgot-ilocks.d: Remove nops in load delay slot.
> * gas/mips/mips-abi32-pic.d: Likewise.
> * gas/mips/mips-abi32-pic2.d: Likewise.
> * gas/mips/mips-gp32-fp32-pic.d: Likewise.
> * gas/mips/mips-gp32-fp64-pic.d: Likewise.
> * gas/mips/mips-gp64-fp32-pic.d: Likewise.
> * gas/mips/mips-gp64-fp64-pic.d: Likewise.
> * gas/mips/relax-swap1-mips2.d: Likewise.
> * gas/mips/lb-svr4pic-ilocks.d: New test.
> * gas/mips/mips.exp: Run it.
>
> The patch for testcases was attached in my first patch mail (no change
> for the revised patch.) Is it better to send a single patch contains
> all change?
I applied those patches, as well as the one appended.
Thiemo
2004-04-22 Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
* config/tc-mips.c (macro): One more use of load_delay_nop.
Index: gas/config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.258
retrieving revision 1.259
diff -u -p -r1.258 -r1.259
--- gas/config/tc-mips.c 22 Apr 2004 18:13:55 -0000 1.258
+++ gas/config/tc-mips.c 22 Apr 2004 22:00:47 -0000 1.259
@@ -7554,8 +7554,7 @@ macro2 (struct mips_cl_insn *ip)
if (treg == tempreg)
return;
/* Protect second load's delay slot. */
- if (!gpr_interlocks)
- macro_build (NULL, "nop", "");
+ load_delay_nop ();
move_register (treg, tempreg);
break;