This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Support COMDAT group for ia64 assembler
On Mon, 2004-05-03 at 16:13, H. J. Lu wrote:
> The problem is in ia64 assembler. I need to handle COMDAT group
> properly in start_unwind_section. This new patch fixes the problem.
This looks reasonable to me. The code that constructs a string argument
for set_section looks like it could be improved, but this interface
isn't your fault. generate_unwind_image lacks a comment, but again that
isn't your fault. start_unwind_section does not have a comment before
it, but the comment inside it seems sufficient. So I think this is OK
as is.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com