This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re[3]: Cygwin tester? Was: [rfa] Add bfd-in-memory io vector
- From: Danny Smith <dannysmith at clear dot net dot nz>
- To: Andrew Cagney <cagney at gnu dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 04 May 2004 12:06:56 +0100
- Subject: Re[3]: Cygwin tester? Was: [rfa] Add bfd-in-memory io vector
- References: <000901c43096$b554fcd0$6e6d65da@DANNY>
- Reply-to: Danny Smith <dannysmith at users dot sourceforge dot net>
----- Original Message -----
From: "Danny Smith"
|
| From: "Danny Smith"
|
| |
| | | > On Sat, May 01, 2004 at 02:10:31PM -0400, Andrew Cagney wrote:
| | | >
| | | >>> The testing comment still applies though.
| | | >
| | | >
| | | > Given DJ's comment, I think you should test this on cygwin before
| | | > committing. If you can't do this yourself, convince someone else
| | | > to do so for you. OK to commit once you've done this.
| | | >
Hi,
Although the patchset works fine (if I add the checks for HAVE_GET[GU]ID)
when building .exe files on pe targets, it fails when building dll's
(segfault in bfd/bfdio.c:bfd_bread when forwarding args to iovec->bread)
With binutils built with CFLAGS="-g -O2", gcc-3.4.0, mingw32:
cat > foo.c
int foo = 1;
^Z
gcc -shared -ofoo.dll foo.c
raises the segfault in bfd_bread.
Actually, the above testcase fails since your 21-April patch.
The problem occurs when pe-dll.c code calls bread with a NULL file, asking for zero bytes
(see comment in cache.c:cache_bread).
The problem can be avoided by doing the cache_bread FIXME in bfd_bread, ie:
*** bfdio.c.cagney Mon May 03 10:02:13 2004
--- bfdio.c Tue May 04 11:26:40 2004
*************** bfd_bread (void *ptr, bfd_size_type size
*** 104,109 ****
--- 104,113 ----
{
size_t nread;
+ /* See FIXME in cache.c:cache_bread(). */
+ if (size == 0)
+ return 0;
+
nread = abfd->iovec->bread (abfd, ptr, size);
if (nread != (size_t) -1)
abfd->where += nread;
With above patch, simple dll build is okay.
But this looks a bit strange in peicode.h:pe_ILF_build_a_bfd()
+ vars.bim = _bfd_in_memory (abfd, abfd->flags, vars.bim->buffer,
+ vars.bim->size);
Should that be:
vars.bim = _bfd_in_memory (abfd, abfd->flags, bim.buffer, bim.size);
Danny