This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [MIPS] Extending -mfix-vr4120 to cope with VR4181A errata


Richard Sandiford wrote:
> The VR4120 core is used in the VR4121, VR4122 and VR4181A.  At the moment,
> -mfix-vr4120 works around errata in the VR412x versions.  This patch extends
> it to cope with the VR4181A multiplication/division errata.
> 
> There are four such errata, MD(1)...MD(4).  However, MD(2) and MD(3) are
> the same as for the VR412x, so new code is only needed for MD(1) and MD(4).
> I've quoted them in the comments.
> 
> Patch tested against the binutils testsuite on mips-elf.  Also tested
> on a combined gcc/binutils tree for mips64vrel-elf (which builds
> -mfix-vr4120 multilibs).  OK to install?

Ok.

> (I guess it's a bit odd adding VR4181A stuff to files called vr4122.[sd],
> but I'd prefer to keep the tests for this option in a single file if
> possible.  Will rename it to fix-vr4120.[sd] or something if you'd prefer.)

I'd prefer vr4120.[sd], as it tests vr4120 specific insns, not only the
errata for it.


Thiemo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]