This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Support mixing COMDAT and linkonce
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: "H. J. Lu" <hjl at lucon dot org>
- Cc: binutils at sources dot redhat dot com
- Date: Sat, 15 May 2004 11:09:47 +0930
- Subject: Re: PATCH: Support mixing COMDAT and linkonce
- References: <20040514210737.GA1087@lucon.org>
On Fri, May 14, 2004 at 02:07:37PM -0700, H. J. Lu wrote:
> When there are mixed COMDAT and linkonce inputs, linker doesn't handle
> them gracefully:
Ewww. Should we even try? I understand that such a patch might be
useful while gcc is emitting both comdat and linkonce, but once you've
completed the change to comdat it shouldn't be necessary. Also, I'm not
really happy with where you have added this code. At least, it is the
wrong place to be discarding duplicate sections. That ought to happen
in ldlang.c:section_already_linked.
--
Alan Modra
IBM OzLabs - Linux Technology Centre