Re: PATCH: Support mixing COMDAT and linkonce

["H. J. Lu" <hjl at lucon dot org>]

On Sat, May 15, 2004 at 11:09:47AM +0930, Alan Modra wrote:
> On Fri, May 14, 2004 at 02:07:37PM -0700, H. J. Lu wrote:
> > When there are mixed COMDAT and linkonce inputs, linker doesn't handle
> > them gracefully:
> 
> Ewww.  Should we even try?  I understand that such a patch might be
> useful while gcc is emitting both comdat and linkonce, but once you've

We can't guarantee everyone will use the same gcc.

> completed the change to comdat it shouldn't be necessary.  Also, I'm not
> really happy with where you have added this code.  At least, it is the
> wrong place to be discarding duplicate sections.  That ought to happen
> in ldlang.c:section_already_linked.

I will see what I can do. I want to check if 2 comdat/linkonce sections 
define the same set of external symbols instead of comparing sizes.


H.J.