This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gas:Reject ++ and --


On Sat, May 22, 2004 at 02:37:24PM +0200, Andreas Schwab wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
> 
> > Even with this fix the ++/-- patch breaks previously working code.
> > E.g. Linux kernel contains:
> > #define MOVE_SHORTCHUNK(src, dst, offset, t0, t1) \
> >         ldub    [%src - offset - 0x02], %t0; \
> >         ldub    [%src - offset - 0x01], %t1; \
> >         stb     %t0, [%dst - offset - 0x02]; \
> >         stb     %t1, [%dst - offset - 0x01];
> > ...
> >         MOVE_SHORTCHUNK(o1, o0, -0x02, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x04, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x06, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x08, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x0a, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x0c, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x0e, g2, g3)
> >         MOVE_SHORTCHUNK(o1, o0, -0x10, g2, g3)
> 
> How about putting parentheses around offset above?

That works and is what I suggested to Tom Callawa.
Still, I'm not sure I like the new gas behaviour.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]