This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: gas:Reject ++ and --
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: Nathan Sidwell <nathan at codesourcery dot com>, Alan Modra <amodra at bigpond dot net dot au>, binutils at sources dot redhat dot com, Michal Ostrowski <mostrows at watson dot ibm dot com>
- Date: Sat, 22 May 2004 11:49:59 -0400
- Subject: Re: gas:Reject ++ and --
- References: <40587B89.5050107@codesourcery.com> <20040416015426.GA2557@bubble.modra.org> <407FFBB1.4000804@codesourcery.com> <20040518193527.GL5191@sunsite.ms.mff.cuni.cz> <je3c5s1vuj.fsf@sykes.suse.de>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Sat, May 22, 2004 at 02:37:24PM +0200, Andreas Schwab wrote:
> Jakub Jelinek <jakub@redhat.com> writes:
>
> > Even with this fix the ++/-- patch breaks previously working code.
> > E.g. Linux kernel contains:
> > #define MOVE_SHORTCHUNK(src, dst, offset, t0, t1) \
> > ldub [%src - offset - 0x02], %t0; \
> > ldub [%src - offset - 0x01], %t1; \
> > stb %t0, [%dst - offset - 0x02]; \
> > stb %t1, [%dst - offset - 0x01];
> > ...
> > MOVE_SHORTCHUNK(o1, o0, -0x02, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x04, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x06, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x08, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x0a, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x0c, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x0e, g2, g3)
> > MOVE_SHORTCHUNK(o1, o0, -0x10, g2, g3)
>
> How about putting parentheses around offset above?
That works and is what I suggested to Tom Callawa.
Still, I'm not sure I like the new gas behaviour.
Jakub