This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: BZ/175: Fix dynamic string offset


On Fri, 2004-05-28 at 08:59, H. J. Lu wrote:
> 	* elfxx-ia64.c (elfNN_ia64_relax_section): Properly call
> 	_bfd_merged_section_offset for local symbols.

Alan suggested asking me, but this is an area of binutils that I don't
understand well.  Richard did most of the IA-64 bfd work.

I do see however that this patch makes the bfd_merged_section_offset
support in elfNN_ia64_relax_section work more like the support in
elfNN_ia64_relocate_section, and on that basis, it does appear correct
to me.  Also, I checked, and this still works for the testcase from
Jakub that prompted him to add the bfd_merged_section_offset call to
elfNN_ia64_relax_section, so this shouldn't be breaking anything.

So this is OK with me.
-- 
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]