This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH]: Support new ColdFire variants
- From: Andreas Schwab <schwab at suse dot de>
- To: Peter Barada <peter at the-baradas dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Sun, 20 Jun 2004 21:33:52 +0200
- Subject: Re: [PATCH]: Support new ColdFire variants
- References: <20040423190358.06186990F2@baradas.org>
Peter Barada <peter@the-baradas.com> writes:
> 2004-04-23 Peter Barada <peter@the-baradas.com>
> * config/tc-m68k.c: Add find_cf_chip to print list of valid
> chips for invalid coldfire instructions, rename selectors
> for ColdFire sub-variants, add 521x,5249,547x,548x and aliases,
> add current_chip to track which chip is referred to(including save/restore),
> use current_chip to select control registers, not current_arch.
> (md_show_usage)Add new chips.
This broke .chip:
$ cat chip.s
.chip 68060
.chip 68k
$ m68k-linux-as chip.s
chip.s: Assembler messages:
chip.s:2: Internal error, aborting at ../../binutils/gas/config/tc-m68k.c line 4395 in select_control_regs
Please report this bug.
I've checked in this fix as obvious.
2004-06-20 Andreas Schwab <schwab@suse.de>
* config/tc-m68k.c (mri_chip): Replace current_chip, not augment.
(md_parse_option): Likewise.
--- gas/config/tc-m68k.c 28 May 2004 23:55:36 +0200 1.54
+++ gas/config/tc-m68k.c 20 Jun 2004 21:16:06 +0200
@@ -5471,7 +5471,7 @@ mri_chip ()
else
current_architecture &= m68881 | m68851;
current_architecture |= archs[i].arch;
- current_chip |= archs[i].chip;
+ current_chip = archs[i].chip;
while (*input_line_pointer == '/')
{
@@ -7264,7 +7264,7 @@ md_parse_option (c, arg)
{
current_architecture &= ~m68000up;
current_architecture |= arch;
- current_chip |= archs[i].chip;
+ current_chip = archs[i].chip;
}
else if (arch == m68881)
{
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, MaxfeldstraÃe 5, 90409 NÃrnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."