This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: mn10300 dynamic relocation clean up: remove dynamic PCREL32


On Mon, Jun 28, 2004 at 04:55:10AM -0300, Alexandre Oliva wrote:
> This patch introduces ELF_LINK_HASH_COMMON, set for symbols read in as
> common symbols.  This bit remains set after the linker turns the

I don't think you need this.  A symbol that was commonl can be detected
after lang_common has run using existing flags, like so

  was_common = ((h->elf_link_hash_flags & ELF_LINK_HASH_DEF_REGULAR) == 0
		&& (h->elf_link_hash_flags & ELF_LINK_HASH_DEF_DYNAMIC) == 0
		&& h->root.type == bfd_link_hash_defined);

Prior to lang_common, just use h->root.type == bfd_link_hash_common.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]