This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
PATCH: Fix sign-extension of bignums
- From: Mark Mitchell <mark at codesourcery dot com>
- To: binutils at sources dot redhat dot com
- Date: Tue, 10 Aug 2004 19:27:03 -0700
- Subject: PATCH: Fix sign-extension of bignums
- Reply-to: mark at codesourcery dot com
Here's a patch for another problem with bignums.
On this input:
.8byte -3378511873
which is a value that fits in 32 bits when treated as unsigned, and
therefore makes it to emit_expr as an O_constant, we failed to
sign-extend the value on output. It looks like we were trying to do
that, but the test "exp->X_add_number < 0" makes no sense; that value
should always be tested with "> 0" or "<= 0", and, furthermore, the "<
0" case would be for floating-point nubmers, which is not this case.
OK?
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
2004-08-10 Mark Mitchell <mark@codesourcery.com>
* read.c (emit_expr): Sign-extend bignums.
Index: read.c
===================================================================
RCS file: /cvs/src/src/gas/read.c,v
retrieving revision 1.78
diff -c -5 -p -r1.78 read.c
*** read.c 19 Apr 2004 09:32:55 -0000 1.78
--- read.c 11 Aug 2004 02:24:11 -0000
*************** emit_expr (expressionS *exp, unsigned in
*** 3486,3496 ****
if (op == O_constant && nbytes > sizeof (valueT))
{
valueT val;
int gencnt;
! if (!exp->X_unsigned && exp->X_add_number < 0)
extra_digit = (valueT) -1;
val = (valueT) exp->X_add_number;
gencnt = 0;
do
{
--- 3486,3496 ----
if (op == O_constant && nbytes > sizeof (valueT))
{
valueT val;
int gencnt;
! if (!exp->X_unsigned && exp->X_add_number > 0)
extra_digit = (valueT) -1;
val = (valueT) exp->X_add_number;
gencnt = 0;
do
{