This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Handle SEC_LINK_DUPLICATES_SAME_CONTENTS for arm-linux


On Wed, Aug 18, 2004 at 10:50:40PM -0700, H. J. Lu wrote:
> On Wed, Aug 18, 2004 at 10:55:19AM -0400, Daniel Jacobowitz wrote:
> So if one of those bfd_malloc/bfd_get_section_contents calls fails,
> it is a success. I am not sure if I like it.

Effectively, fall back to just a size check.  I think that's
reasonable.

> > +		  if (sec_contents)
> > +		    free (sec_contents);
> > +		  if (l_sec_contents)
> > +		    free (l_sec_contents);
> > +		}
> > +	      break;
> >  	    }
> >  
> >  	  /* Set the output_section field so that lang_add_section
> 
> Will this compile for mainline? Alan has removed bfd_archive_filename
> with his error_handler change.

No, presumably Daniel will fix that before applying.  Daniel, you
could use bfd_malloc_and_get_section here too.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]