This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Fix relro when COMMONPAGESIZE < MAXPAGESIZE
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, binutils at sources dot redhat dot com
- Date: Tue, 7 Sep 2004 14:49:02 -0400 (EDT)
- Subject: Re: Fix relro when COMMONPAGESIZE < MAXPAGESIZE
- References: <jebrgon0i1.fsf@sykes.suse.de> <20040907134604.GP30497@sunsite.ms.mff.cuni.cz>
On Tue, 7 Sep 2004, Jakub Jelinek wrote:
> On Thu, Sep 02, 2004 at 05:39:34PM +0200, Andreas Schwab wrote:
> > Adjusting the relro end address during DATA_SEGMENT_ALIGN throws aways any
> > previous data segment alignment, causing the resulting binary to contain a
> > big hole.
>
> Can you post readelf -WS output before and after the patch?
> The big hole was certainly intended there, so that MAXPAGESIZE is properly
> honored. After all, it is just diskspace (well, ld creates sparse file),
> not memory.
"Diskspace" might be solid-state media (usually flash ROM) which
is certainly not inexpensive. (And the flash file-system might
not support sparse files.)
Please, whenever you make a change to increase the size of
anything available at execution time, please remember that not
all "diskspace" is cheap, and make the size-increasing
functionality an *option*.
brgds, H-P