This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR 414: Linker crashes with mixed TLS/non-TLS symbols

From: Alan Modra <amodra at bigpond dot net dot au>
To: binutils at sources dot redhat dot com
Date: Fri, 1 Oct 2004 20:42:20 +0930
Subject: Re: PATCH: PR 414: Linker crashes with mixed TLS/non-TLS symbols
References: <200409221737.06059.pluto@pld-linux.org> <20040922155522.GB12940@lucon.org> <200409221827.29089.pluto@pld-linux.org> <20040929164702.GA21672@lucon.org> <20040929173833.GA22511@lucon.org> <20040929232640.GA3241@bubble.modra.org> <20041001021814.GA23666@bubble.modra.org>

On Fri, Oct 01, 2004 at 11:48:14AM +0930, Alan Modra wrote:
> HJ's patch brought to light some errors in the ld testsuite.

Some more.

	* ld-s390/tlsbin.s: Set tls type for undefined syms.
	* ld-s390/tlsbin_64.s: Likewise.
	* ld-s390/tlsbinpic.s: Likewise.
	* ld-s390/tlsbinpic_64.s: Likewise.
	* ld-s390/tlspic1.s: Likewise.
	* ld-s390/tlspic1_64.s: Likewise.
	* ld-sparc/tlssunbin32.s: Likewise.
	* ld-sparc/tlssunbinpic32.s: Likewise.
	* ld-sparc/tlssunnopic32.s: Likewise.
	* ld-sparc/tlssunpic32.s: Likewise.

An unrelated fix for one of the sparc testsuite failures.

	* ld-sparc/tlssunbin32.sd: Adjust for changed .dynamic location.

Index: ld/testsuite/ld-s390/tlsbin.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-s390/tlsbin.s,v
retrieving revision 1.1
diff -u -p -r1.1 tlsbin.s
--- ld/testsuite/ld-s390/tlsbin.s	24 Jan 2003 17:18:12 -0000	1.1
+++ ld/testsuite/ld-s390/tlsbin.s	1 Oct 2004 11:04:55 -0000
@@ -16,6 +16,11 @@ bl5:	.space 4
 bl6:	.space 4
 bl7:	.space 4
 bl8:	.space 4
+
+	.type sG6,@tls_object
+	.type sh6,@tls_object
+	.type sg3,@tls_object
+
 	.text
 	.globl	_start
 	.type	_start,@function
Index: ld/testsuite/ld-s390/tlsbin_64.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-s390/tlsbin_64.s,v
retrieving revision 1.1
diff -u -p -r1.1 tlsbin_64.s
--- ld/testsuite/ld-s390/tlsbin_64.s	24 Jan 2003 17:18:12 -0000	1.1
+++ ld/testsuite/ld-s390/tlsbin_64.s	1 Oct 2004 11:04:55 -0000
@@ -16,6 +16,11 @@ bl5:	.space 4
 bl6:	.space 4
 bl7:	.space 4
 bl8:	.space 4
+
+	.type sG6,@tls_object
+	.type sh6,@tls_object
+	.type sg3,@tls_object
+
 	.text
 	.globl	_start
 	.type	_start,@function
Index: ld/testsuite/ld-s390/tlsbinpic.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-s390/tlsbinpic.s,v
retrieving revision 1.2
diff -u -p -r1.2 tlsbinpic.s
--- ld/testsuite/ld-s390/tlsbinpic.s	11 May 2004 17:08:35 -0000	1.2
+++ ld/testsuite/ld-s390/tlsbinpic.s	1 Oct 2004 11:04:55 -0000
@@ -28,6 +28,11 @@ sh5:	.long 261
 sh6:	.long 262
 sh7:	.long 263
 sh8:	.long 264
+
+	.type sG1,@tls_object
+	.type sG2,@tls_object
+	.type sG3,@tls_object
+
 	.text
 	.globl	fn2
 	.type	fn2,@function
Index: ld/testsuite/ld-s390/tlsbinpic_64.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-s390/tlsbinpic_64.s,v
retrieving revision 1.2
diff -u -p -r1.2 tlsbinpic_64.s
--- ld/testsuite/ld-s390/tlsbinpic_64.s	11 May 2004 17:08:35 -0000	1.2
+++ ld/testsuite/ld-s390/tlsbinpic_64.s	1 Oct 2004 11:04:55 -0000
@@ -28,6 +28,11 @@ sh5:	.long 261
 sh6:	.long 262
 sh7:	.long 263
 sh8:	.long 264
+
+	.type sG1,@tls_object
+	.type sG2,@tls_object
+	.type sG3,@tls_object
+
 	.text
 	.globl	fn2
 	.type	fn2,@function
Index: ld/testsuite/ld-s390/tlspic1.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-s390/tlspic1.s,v
retrieving revision 1.2
diff -u -p -r1.2 tlspic1.s
--- ld/testsuite/ld-s390/tlspic1.s	11 May 2004 17:08:35 -0000	1.2
+++ ld/testsuite/ld-s390/tlspic1.s	1 Oct 2004 11:04:55 -0000
@@ -27,6 +27,11 @@ sh5:	.long 261
 sh6:	.long 262
 sh7:	.long 263
 sh8:	.long 264
+
+	.type sH1,@tls_object
+	.type sH2,@tls_object
+	.type sH5,@tls_object
+
 	.text
 	.globl	fn1
 	.type	fn1,@function
Index: ld/testsuite/ld-s390/tlspic1_64.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-s390/tlspic1_64.s,v
retrieving revision 1.2
diff -u -p -r1.2 tlspic1_64.s
--- ld/testsuite/ld-s390/tlspic1_64.s	11 May 2004 17:08:35 -0000	1.2
+++ ld/testsuite/ld-s390/tlspic1_64.s	1 Oct 2004 11:04:55 -0000
@@ -27,6 +27,11 @@ sh5:	.long 261
 sh6:	.long 262
 sh7:	.long 263
 sh8:	.long 264
+
+	.type sH1,@tls_object
+	.type sH2,@tls_object
+	.type sH5,@tls_object
+
 	.text
 	.globl	fn1
 	.type	fn1,@function
Index: ld/testsuite/ld-sparc/tlssunbin32.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sparc/tlssunbin32.s,v
retrieving revision 1.1
diff -u -p -r1.1 tlssunbin32.s
--- ld/testsuite/ld-sparc/tlssunbin32.s	24 Jan 2003 23:44:45 -0000	1.1
+++ ld/testsuite/ld-sparc/tlssunbin32.s	1 Oct 2004 11:04:55 -0000
@@ -17,6 +17,14 @@ bl5:	.word 0
 bl6:	.word 0
 bl7:	.word 0
 bl8:	.word 0
+
+	.type sg2,@tls_object
+	.type sg3,@tls_object
+	.type sG6,@tls_object
+	.type sh2,@tls_object
+	.type sh3,@tls_object
+	.type sh6,@tls_object
+
 	.text
 	.globl	_start
 	.type	_start,#function
Index: ld/testsuite/ld-sparc/tlssunbin32.sd
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sparc/tlssunbin32.sd,v
retrieving revision 1.2
diff -u -p -r1.2 tlssunbin32.sd
--- ld/testsuite/ld-sparc/tlssunbin32.sd	1 Jul 2004 16:24:51 -0000	1.2
+++ ld/testsuite/ld-sparc/tlssunbin32.sd	1 Oct 2004 11:04:55 -0000
@@ -7,5 +7,5 @@
 .*: +file format elf32-sparc
 
 Contents of section .got:
- 23278 00025060 0+ 0+ 0+  .*
+ 23278 000231f8 0+ 0+ 0+  .*
  23288 0+  .*
Index: ld/testsuite/ld-sparc/tlssunbinpic32.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sparc/tlssunbinpic32.s,v
retrieving revision 1.1
diff -u -p -r1.1 tlssunbinpic32.s
--- ld/testsuite/ld-sparc/tlssunbinpic32.s	24 Jan 2003 23:44:45 -0000	1.1
+++ ld/testsuite/ld-sparc/tlssunbinpic32.s	1 Oct 2004 11:04:55 -0000
@@ -30,6 +30,11 @@ sh5:	.word 261
 sh6:	.word 262
 sh7:	.word 263
 sh8:	.word 264
+
+	.type sG1,@tls_object
+	.type sG2,@tls_object
+	.type sG5,@tls_object
+
 	.text
 	.align	4096
 .LLGETPC0:
Index: ld/testsuite/ld-sparc/tlssunnopic32.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sparc/tlssunnopic32.s,v
retrieving revision 1.1
diff -u -p -r1.1 tlssunnopic32.s
--- ld/testsuite/ld-sparc/tlssunnopic32.s	24 Jan 2003 23:44:45 -0000	1.1
+++ ld/testsuite/ld-sparc/tlssunnopic32.s	1 Oct 2004 11:04:55 -0000
@@ -7,6 +7,11 @@ bl2:	.word 0
 bl3:	.word 0
 bl4:	.word 0
 bl5:	.word 0
+
+	.type sh1,@tls_object
+	.type sh2,@tls_object
+	.type sh3,@tls_object
+
 	.text
 	.align	4096
 	.globl	fn3
Index: ld/testsuite/ld-sparc/tlssunpic32.s
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-sparc/tlssunpic32.s,v
retrieving revision 1.1
diff -u -p -r1.1 tlssunpic32.s
--- ld/testsuite/ld-sparc/tlssunpic32.s	24 Jan 2003 23:44:45 -0000	1.1
+++ ld/testsuite/ld-sparc/tlssunpic32.s	1 Oct 2004 11:04:55 -0000
@@ -30,6 +30,10 @@ sh6:	.word 262
 sh7:	.word 263
 sh8:	.word 264
 
+	.type sH1,@tls_object
+	.type sH2,@tls_object
+	.type sH5,@tls_object
+
 	.text
 	.align	4096
 .LLGETPC0:

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre

Follow-Ups:
- Re: PATCH: PR 414: Linker crashes with mixed TLS/non-TLS symbols
  - From: H. J. Lu

References:
- Re: PATCH: PR 414: Linker crashes with mixed TLS/non-TLS symbols
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]