This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
fix objdump -t on arm
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: binutils at sources dot redhat dot com
- Date: Mon, 11 Oct 2004 17:48:08 +0930
- Subject: fix objdump -t on arm
Using a continue meant we weren't incrementing current..
* objdump.c (dump_symbols): Fix thinko last change. Improve error
messages.
Index: binutils/objdump.c
===================================================================
RCS file: /cvs/src/src/binutils/objdump.c,v
retrieving revision 1.95
diff -u -p -r1.95 objdump.c
--- binutils/objdump.c 8 Oct 2004 14:54:03 -0000 1.95
+++ binutils/objdump.c 11 Oct 2004 07:56:57 -0000
@@ -2280,17 +2280,14 @@ dump_symbols (bfd *abfd ATTRIBUTE_UNUSED
bfd *cur_bfd;
if (*current == NULL)
- printf (_("no information for the %ld'th symbol"), count);
+ printf (_("no information for symbol number %ld\n"), count);
else if ((cur_bfd = bfd_asymbol_bfd (*current)) == NULL)
- printf (_("could not determine the type of the %ld'th symbol"),
+ printf (_("could not determine the type of symbol number %ld\n"),
count);
- else if (! dump_special_syms
- && bfd_is_target_special_symbol (cur_bfd, *current))
- continue;
-
- else
+ else if (dump_special_syms
+ || !bfd_is_target_special_symbol (cur_bfd, *current))
{
const char *name = (*current)->name;
@@ -2311,9 +2308,8 @@ dump_symbols (bfd *abfd ATTRIBUTE_UNUSED
else
bfd_print_symbol (cur_bfd, stdout, *current,
bfd_print_symbol_all);
+ printf ("\n");
}
-
- printf ("\n");
current++;
}
printf ("\n\n");
--
Alan Modra
IBM OzLabs - Linux Technology Centre