This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] some x86 instructions tagged with incorrect CPU type
- From: "H. J. Lu" <hjl at lucon dot org>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 19 Nov 2004 11:33:33 -0800
- Subject: Re: [PATCH] some x86 instructions tagged with incorrect CPU type
- References: <s19cce7b.005@emea1-mh.id2.novell.com>
On Thu, Nov 18, 2004 at 05:33:08PM +0100, Jan Beulich wrote:
> >>> "H. J. Lu" <hjl@lucon.org> 16.11.04 20:40:30 >>>
> >The first problem is the patched assemebler failed "make check" for
> >x86-64. I got
>
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
> >Assembler messages:
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Warning: `aaa' is not supported in 64-bit mode
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Error: suffix or operands invalid for `aaa'
> >
> >instead of
> >
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
> >Assembler messages:
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Error: suffix or operands invalid for `aaa'
> >
> >I would prefer just
> >
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:
> >Assembler messages:
> >/net/gnu//export/linux/src/binutils/binutils/gas/testsuite/gas/i386/x86-64-inval.s:3:
> Error: `aaa' is not supported in 64-bit mode
>
> This is easily fixed, as below/attached. Built/tested on
> i686-pc-linux-gnu
> (this time also as cross assembler targeting
> x86_64-unknown-linux-gnu).
> Despite finding this more desirable, too, I didn't originally dare to
> make
> these errors because they weren't before.
>
This is OK. Please apply.
Thanks.
H.J.