This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Correct dst_mask for R_MIPS_JALR in elfn32-mips.c
- From: Ian Lance Taylor <ian at wasabisystems dot com>
- To: binutils at sourceware dot org
- Date: 9 Dec 2004 01:32:23 -0500
- Subject: Correct dst_mask for R_MIPS_JALR in elfn32-mips.c
In the MIPS n32 ABI, R_MIPS_JALR is an optimization hint which does
not cause any output. Therefore, the corresponding howto entry should
have a dst_mask of 0, indicating that no bits are affected.
R_MIPS_JALR is defined twice in elfn32-mips.c, once for SHT_REL
sections and once for SHT_RELA sections. The first has a correct
dst_mask of 0. The second one does not. This patch, which I am about
to commit, fixes it.
Ian
2004-12-09 Ian Lance Taylor <ian@wasabisystems.com>
* elfn32-mips.c (elf_mips_howto_table_rela): Change dst_mask of
R_MIPS_JALR entry to 0.
Index: elfn32-mips.c
===================================================================
RCS file: /cvs/src/src/bfd/elfn32-mips.c,v
retrieving revision 1.20
diff -u -r1.20 elfn32-mips.c
--- elfn32-mips.c 29 Jun 2004 13:46:34 -0000 1.20
+++ elfn32-mips.c 9 Dec 2004 06:24:38 -0000
@@ -1115,7 +1115,7 @@
"R_MIPS_JALR", /* name */
FALSE, /* partial_inplace */
0, /* src_mask */
- 0xffffffff, /* dst_mask */
+ 0, /* dst_mask */
FALSE), /* pcrel_offset */
};