This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
PATCH: Ignore --disable-static in libiberty
- From: "H. J. Lu" <hjl at lucon dot org>
- To: binutils at sources dot redhat dot com, gcc-patches at gcc dot gnu dot org,gcc at gcc dot gnu dot org
- Date: Sat, 18 Dec 2004 19:42:27 -0800
- Subject: PATCH: Ignore --disable-static in libiberty
I was told that my libiberty patch caused gcc bootstrap failure with
--disable-static:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=19072
It was a surprise to me. As far as I know, libiberty never properly
supported --disable-static. Basically, libiberty just ignored it. A
static archive, which wasn't compiled with PIC, was built. With my
patch, libiberty tries not to build the static archive, which, of
course, isn't supported by libiberty. This patch makes libiberty
to ignore --disable-static again. But I don't think --disable-static
ever worked on all platforms, at least not in binutils.
H.J.
----
2004-12-18 H.J. Lu <hongjiu.lu@intel.com>
PR bootstrap/19072
* configure.ac (enable_static): Set to yes.
(AC_PROG_LIBTOOL): Removed.
(AM_DISABLE_SHARED): Uncommented.
(AM_PROG_LIBTOOL): Likewise.
* configure: Regenerated.
--- libiberty/configure.ac.static 2004-12-18 08:58:19.000000000 -0800
+++ libiberty/configure.ac 2004-12-18 19:23:01.935539645 -0800
@@ -4,6 +4,9 @@ AC_PREREQ(2.59)
AC_INIT
AC_CONFIG_SRCDIR([xmalloc.c])
+# FIXME: libiberty doesn't support --disable-static
+enable_static=yes
+
# This works around the fact that libtool configuration may change LD
# for this particular configuration, but some shells, instead of
# keeping the changes in LD private, export them just because LD is
@@ -113,8 +116,6 @@ GCC_NO_EXECUTABLES
AC_PROG_CC
AC_PROG_CPP_WERROR
-AC_PROG_LIBTOOL
-
if test x$GCC = xyes; then
ac_libiberty_warn_cflags='-W -Wall -Wtraditional -pedantic'
fi
@@ -124,13 +125,11 @@ AC_C_CONST
AC_C_INLINE
AC_C_BIGENDIAN_CROSS
-dnl When we start using libtool:
dnl Default to a non shared library. This may be overridden by the
dnl configure option --enable-shared.
-dnl AM_DISABLE_SHARED
+AM_DISABLE_SHARED
-dnl When we start using libtool:
-dnl AM_PROG_LIBTOOL
+AM_PROG_LIBTOOL
dnl When we start using automake:
dnl AM_CONFIG_HEADER(config.h:config.in)