This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Use $(SHELL) when running move-if-change
- From: Ben Elliston <bje at au dot ibm dot com>
- To: binutils at sources dot redhat dot com
- Date: 21 Dec 2004 10:50:24 +1100
- Subject: Re: Use $(SHELL) when running move-if-change
- References: <20041220212226.32268.qmail@gossamer.airs.com>
Ian Lance Taylor <ian@airs.com> writes:
> I'm checking in this patch to bfd/doc/Makefile.am to use $(SHELL)
> when running move-if-change. $(SHELL) should always be used with
> move-if-change or indeed any shell script. I suppose this one went
> unfixed for so long because it is only run when recreating info
> files, which normally does not need to be done when using a released
> version.
While we're discussing move-if-change here is a trivial patch that has
been sitting in my tree for some time. I always build with make -s,
so this bugs me perhaps more than most. Like mv(1), move-if-change
should be silent, too. Okay for mainline?
2004-11-01 Ben Elliston <bje@au.ibm.com>
* move-if-change: Don't produce any output, just like mv(1).
Index: move-if-change
===================================================================
RCS file: /home/bje/gcc-cvs/gcc/move-if-change,v
retrieving revision 1.3
diff -u -p -r1.3 move-if-change
--- move-if-change 11 Jan 1999 14:12:18 -0000 1.3
+++ move-if-change 20 Dec 2004 23:48:07 -0000
@@ -1,6 +1,6 @@
#!/bin/sh
-# Copyright (C) 1996 Free Software Foundation, Inc.
+# Copyright (C) 1996, 2004 Free Software Foundation, Inc.
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -22,7 +22,6 @@ then
if
cmp $1 $2 > /dev/null
then
-echo $2 is unchanged
rm -f $1
else
mv -f $1 $2