This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add a second 'pinfo' member to mips_opcode to extendnumber of available bits

From: Eric Christopher <echristo at redhat dot com>
To: Richard Sandiford <rsandifo at redhat dot com>
Cc: fnf at specifixinc dot com, binutils at sources dot redhat dot com
Date: Thu, 20 Jan 2005 09:59:41 -0800
Subject: Re: [PATCH] Add a second 'pinfo' member to mips_opcode to extendnumber of available bits
References: <200501191519.59986.fnf@specifixinc.com> <wvnmzv471xr.fsf@talisman.cambridge.redhat.com>

On Thu, 2005-01-20 at 11:52 +0000, Richard Sandiford wrote:
> Fred Fish <fnf@specifixinc.com> writes:
> > 	(INSN_ALIAS): New define for opcode table entries that are
> > 	specific instances of another entry, such as 'move' for an 'or'
> > 	with a zero operand.
> > 	(INSN_READ_MDMX_ACC): Redefine from 0 to 0x2.
> > 	(INSN_WRITE_MDMX_ACC): Redefine from 0 to 0x4.
> 
> Just a suggestion (I've no authority here ;) but maybe it would
> be better to use names like INSN2_* for flags that apply to pinfo2?
> Less chance of using the wrong pinfo field accidentally.

Seems like a good idea to me.

-eric

Follow-Ups:
- Re: [PATCH] Add a second 'pinfo' member to mips_opcode to extend number of available bits
  - From: Fred Fish

References:
- [PATCH] Add a second 'pinfo' member to mips_opcode to extend number of available bits
  - From: Fred Fish
- Re: [PATCH] Add a second 'pinfo' member to mips_opcode to extendnumber of available bits
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]