This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gas cleanups


"Ben Elliston" <bje@au1.ibm.com> writes:

> -#if 0
> -  /* Alpha-OSF1 adds "the offset of saved $a0 from $sp", according to
> -     Sandro.  I don't yet know where this value should be stored, if
> -     anywhere.  */
> -  demand_empty_rest_of_line ();
> -#else
>    s_ignore (42);
> -#endif

You need to keep this comment, to explain why we aren't calling
demand_empty_rest_of_line().

> -#if 0
> -      /* This test is triggered inappropriately for the SH.  */
> -      if (fixp->fx_where + fixp->fx_size
> -	  > fixp->fx_frag->fr_fix + fixp->fx_frag->fr_offset)
> -	abort ();
> -#endif

Anybody know what's up with this?  That test looks pretty darn good to
me, and anything which fails it looks pretty darn suspect.

This patch is OK if you keep the comment in the first paragraph above,
and don't remove the #if 0 code in the second paragraph above.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]