This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64 application register handling
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 26 Jan 2005 17:52:24 -0800
- Subject: Re: [PATCH] ia64 application register handling
- References: <s1f4c4d9.092@emea1-mh.id2.novell.com>
On Mon, 2005-01-24 at 01:50, Jan Beulich wrote:
> * config/tc-ia64.c (emit_one_bundle): Add late resolution of
> move
> to/from application registers dynamic insns.
> (md_assemble): Defer resolution of move to/from application
> registers
> dynamic insns when they can be issued on either the I- or
> M-units.
Ok.
In the emit_one_bundle hunk, inside the #if 0, you accidentally lost a
comment. However, this code is long obsolete. An idesc no longer has a
next field; this was dropped even before the code was contributed to the
FSF. I suspect this happened when Bob Manson wrote the ia64-gen.c
program. So we should just drop this #if 0 code instead of putting the
comment back.
As for the use of [:stuff:], I don't have a strong opinion. It is fine
with me. Since you are only adding this to IA-64 specific tests,
perhaps it won't be a problem for H-P. As far as I know, he isn't doing
any IA-64 specific testing. If you added this to generic tests, then it
would be a serious problem for him. H-P says the feature has been there
since at least tcl/tk 8.2.3, which I see was released Dec 16, 1999.
That was over 5 years ago, before there were even any IA-64 operating
systems available. I don't see why we need to restrict IA-64 testcases
in order to support old versions of tcl/tk. I think it would be
reasonable to require at least tcl/tk 8.2.3 to run the binutils
testsuite. I don't mind if someone wants to overrule me though.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com