This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64 application register handling
- From: "Jan Beulich" <JBeulich at novell dot com>
- To: <wilson at specifixinc dot com>
- Cc: <binutils at sources dot redhat dot com>
- Date: Thu, 27 Jan 2005 09:40:49 +0100
- Subject: Re: [PATCH] ia64 application register handling
>In the emit_one_bundle hunk, inside the #if 0, you accidentally lost a
>comment. However, this code is long obsolete. An idesc no longer has
a
>next field; this was dropped even before the code was contributed to
the
>FSF. I suspect this happened when Bob Manson wrote the ia64-gen.c
>program. So we should just drop this #if 0 code instead of putting
the
>comment back.
Actually, the comment wasn't lost accidently, but intentionally. But
maybe it should have been modified slightly by adding the word 'other'.
Since this was in an #if 0 block, thus counting as comment, I took the
freedom to slightly change this to
#if 0
- know (!idesc->next); /* no resolved dynamic ops have
collisions */
+ else
+ /* no other resolved dynamic ops have collisions */
+ know (!get_next_opcode (idesc));
#endif
Jan