Re: [RFA:] Prepend "warning: " to "user" linker warnings, as ELF does.

[Ian Lance Taylor <ian at airs dot com>]

Hans-Peter Nilsson <hans-peter.nilsson@axis.com> writes:

> The ELF section warning construct was recentlish (2003-08-04)
> changed to have "warning: " prepended, so for symmetry I suggest
> all (i.e. including the a.out stabs construct) do the same (or
> I'll have to submit the corresponding a/symmetric patch to
> newlib).  I expect even less breakage on a.out, compared to the
> ELF-only change. ;-)  No test-cases need be adjusted, but
> forthcoming test-cases depend on this.
> 
> Since the ELF warnings go through here, that "warning: " string
> would be doubled, so I removed it.  Yay, removed code!
> Translating "warning: " for *those* messages in ldmain.c is now
> inconsistent; other "warning: " strings aren't.  Should they all
> be translated or left alone?
> 
> Ok to commit?
> 
> bfd:
> 	* elflink.c (elf_link_add_object_symbols): Don't add "warning: "
> 	prefix here.
> 
> ld:
> 	* ldmain.c (warning_callback, warning_find_reloc): Prepend
> 	"warning: " to warning messages.

I think this patch is OK, but please give it 24 hours in case somebody
doesn't like it.

I think in general the "warning:" string should be translated.

Ian