This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
RE: ld/emultempl/elf32.em trusts inode numbers even under Mingwin
- From: "Dave Korn" <dave dot korn at artimi dot com>
- To: "'Zack Weinberg'" <zack at codesourcery dot com>
- Cc: "'Binutils Mailing List'" <binutils at sources dot redhat dot com>
- Date: Wed, 9 Feb 2005 14:31:51 -0000
- Subject: RE: ld/emultempl/elf32.em trusts inode numbers even under Mingwin
> -----Original Message-----
> From: Zack Weinberg
> Sent: 08 February 2005 20:19
> It was indeed NFS remote. I agree, testing inode == 0 ought to be
> adequate. Here's a revised patch.
Looks good to me, although I'm not a mingw expert. The only tiny nit I might
pick would perhaps be to extend the comment slightly by explicitly mentioning
that even if a bogus match on st_inode == 0 ever did occur, it would only be a
missed optimisation rather than actually cause any harm; that's only an
implication at the moment.
cheers,
DaveK
--
Can't think of a witty .sigline today....