This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch] SymbianOS Arm executables
On Thu, 2005-02-10 at 15:45, Paul Brook wrote:
> On Thursday 10 February 2005 10:55, Richard Earnshaw wrote:
> > I'm uncomfortable about the way globals->symbian_p is getting scattered
> > throughout the entire linking process. I think we really need to try
> > and distill that variable into the effects it has on linking (this would
> > then make porting the linker to platforms with similar properties much
> > less painful).
> >
> > In this case you've already identified the abstract property: the
> > executable is relocated at link time. Most of your used of ->symbian_p
> > should therefore be ->exec_reloc_p. There should then be exactly one
> > place where symbian_p is tested, and that is then used to set the
> > exec_reloc_p property.
>
> Modified patch attached. No functional changes.
>
That looks much better.
> Retested on i686-linux, arm-none-elf and arm-none-symbianelf.
> Ok?
The ARM parts are OK, but I can't approve the other bits.
R.