This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: TLS support for MIPS


On Mon, Feb 21, 2005 at 10:52:14AM -0500, Daniel Jacobowitz wrote:
> On Tue, Feb 08, 2005 at 03:46:02PM +1030, Alan Modra wrote:
> > On Mon, Feb 07, 2005 at 06:00:14PM -0500, Daniel Jacobowitz wrote:
> > > 	* elflink.c: Don't exclude sections based on a shared library input.
> > 
> > This would be better in ldlang_add_file, I think.
> 
> Like so?  Tested on a bunch of different MIPS configurations, with no
> problems.  Only thing it might affect is --just-syms with a dynamic
> object... well, don't do that then.

Yes, don't do that.  elflink.c:3268

      /* ld --just-symbols and dynamic objects don't mix very well.
	 Test for --just-symbols by looking at info set up by
	 _bfd_elf_link_just_syms.  */
      if ((s = abfd->sections) != NULL
	  && s->sec_info_type == ELF_INFO_TYPE_JUST_SYMS)
	goto error_return;

But of course doing as I suggested means we don't get sec_info_type
set and the error isn't caught.  So maybe you'd better do

 	* ldlang.c (section_already_linked): Don't call
	bfd_section_already_linked for dynamic objects.

Patch pre-approved.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]