This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Fix ARM local label test for COFF based ports
- From: Nick Clifton <nickc at redhat dot com>
- To: binutils at sources dot redhat dot com
- Date: Tue, 01 Mar 2005 15:50:47 +0000
- Subject: Fix ARM local label test for COFF based ports
Hi Guys,
I am applying the patch below to fix an unexpected failure in the
GAS testsuite when testing a COFF based ARM port. The problem is
that the COFF targeted ports have a different definition of how a
local symbol name should be constructed.
Cheers
Nick
gas/testsuite/ChangeLog
2005-03-01 Nick Clifton <nickc@redhat.com>
* gas/arm/arm.exp (undefined): Run a COFF variant of this test for
COFF based ports.
* gas/arm/undefined_coff.s: New file: Variant of undefined.s but
with a COFF formated local label name.
* gas/arm/undefined_coff.l: New file. Variant of undefined.l.
Index: gas/testsuite/gas/arm/arm.exp
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/arm/arm.exp,v
retrieving revision 1.33
diff -c -3 -p -r1.33 arm.exp
*** gas/testsuite/gas/arm/arm.exp 5 Oct 2004 13:51:39 -0000 1.33
--- gas/testsuite/gas/arm/arm.exp 1 Mar 2005 15:34:36 -0000
*************** if {[istarget *arm*-*-*] || [istarget "x
*** 56,68 ****
run_errors_test "req" "-mcpu=arm7m" ".req errors"
run_errors_test "armv1-bad" "-mcpu=arm7m" "ARM v1 errors"
run_errors_test "r15-bad" "" "Invalid use of r15 errors"
- run_errors_test "undefined" "" "Undefined local label error"
if {[istarget *-*-*elf*] || [istarget *-*-linux*] || [istarget *-*-*eabi]} then {
run_dump_test "pic"
run_dump_test "mapping"
gas_test "bignum1.s" "" $stdoptlist "bignums"
run_dump_test "unwind"
}
if {! [istarget arm*-*-aout] && ![istarget arm-*-pe]} then {
--- 56,71 ----
run_errors_test "req" "-mcpu=arm7m" ".req errors"
run_errors_test "armv1-bad" "-mcpu=arm7m" "ARM v1 errors"
run_errors_test "r15-bad" "" "Invalid use of r15 errors"
if {[istarget *-*-*elf*] || [istarget *-*-linux*] || [istarget *-*-*eabi]} then {
+ run_errors_test "undefined" "" "Undefined local label error"
run_dump_test "pic"
run_dump_test "mapping"
gas_test "bignum1.s" "" $stdoptlist "bignums"
run_dump_test "unwind"
+ } else {
+ # COFF based ports use a different naming convention for local labels.
+ run_errors_test "undefined_coff" "" "Undefined local label error"
}
if {! [istarget arm*-*-aout] && ![istarget arm-*-pe]} then {
*** /dev/null 2004-06-24 19:04:38.000000000 +0100
--- gas/testsuite/gas/arm/undefined_coff.s 2005-03-01 15:44:24.000000000 +0000
***************
*** 0 ****
--- 1 ----
+ ldr a1, Lval
*** /dev/null 2004-06-24 19:04:38.000000000 +0100
--- gas/testsuite/gas/arm/undefined_coff.l 2005-03-01 15:45:09.000000000 +0000
***************
*** 0 ****
--- 1,2 ----
+ [^:]*: Assembler messages:
+ [^:]*:1: Error: undefined local label `Lval'