This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Remove redundant code in gas/expr.c


Hi Guys,

  Whilst investigating another problem I am across the fact that we
  have a small piece of redundant code in expr.c:operand().  It was
  enclosed inside a #ifdef RELAX_PAREN_GROUPING...#endif which is not
  defined by any target.  So I am applying this patch to remove it.

Cheers
  Nick

gas/ChangeLog
2005-03-03  Nick Clifton  <nickc@redhat.com>

	* expr.c (operand): Remove redundant code enclosed by #ifdef
	RELAX_PAREN_GROUPING....#endif.

Index: gas/expr.c
===================================================================
RCS file: /cvs/src/src/gas/expr.c,v
retrieving revision 1.54
diff -c -3 -p -r1.54 expr.c
*** gas/expr.c	1 Mar 2005 22:35:21 -0000	1.54
--- gas/expr.c	3 Mar 2005 17:17:15 -0000
*************** operand (expressionS *expressionP)
*** 977,988 ****
        /* expression () will pass trailing whitespace.  */
        if ((c == '(' && *input_line_pointer != ')')
  	  || (c == '[' && *input_line_pointer != ']'))
! 	{
! #ifdef RELAX_PAREN_GROUPING
! 	  if (c != '(')
! #endif
! 	    as_bad (_("missing '%c'"), c == '(' ? ')' : ']');
! 	}
        else
  	input_line_pointer++;
        SKIP_WHITESPACE ();
--- 977,983 ----
        /* expression () will pass trailing whitespace.  */
        if ((c == '(' && *input_line_pointer != ')')
  	  || (c == '[' && *input_line_pointer != ']'))
! 	as_bad (_("missing '%c'"), c == '(' ? ')' : ']');
        else
  	input_line_pointer++;
        SKIP_WHITESPACE ();
  


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]