This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: gas/config/tc-tic54x.c's use of macro_struct and formal_struct


Since it looks like I moved those structs into macro.h in the first place to make them publicly accessible, I'm guessing the duplicated code in the tic54x file pre-dates moving the structs into macro.h, and was never properly cleaned up.

Please contribute a patch.

T.

On Mar 9, 2005, at 7:56 AM, Nick Clifton wrote:

Hi Jan,

As I'm intending to add one or two elements to macro_struct (to allow
.purgem to free the memory allocated by .macro) I'd like to understand
what, if any, reasons there are for this file, in function
tic54x_macro_info, to redeclare these two structures instead of using
them (or even better their typedef equivalents) from the already
included macro.h.

As far as I can tell this was an ill-advised piece of coding. The typedefs from macro.h should have been used as you suggested. Please feel free to contribute a patch to do just this.


Cheers
  Nick




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]