This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] VAX: produce valid assembler when disassembling function mask
- From: Jan-Benedict Glaw <jbglaw at microdata-pos dot de>
- To: Nick Clifton <nickc at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 14 Mar 2005 10:48:09 +0100
- Subject: Re: [PATCH] VAX: produce valid assembler when disassembling function mask
- References: <20050311233046.A24051@microdata-pos.de> <42355DCF.7050302@redhat.com>
On Mon, Mar 14, 2005 at 09:47:59AM +0000, Nick Clifton wrote:
> > When I introduced decoding of VAXens function entry mask some days
> > ago, I missed to let the output look like assembler. Using .word
> > and a comment was suggested by Kenn Humborg and I think it's a good
> > idea.
> >
> > 2005-03-11 Jan-Benedict Glaw <jbglaw@lug-owl.de>
> >
> > * vax-dis.c: Fix spelling error
> > (print_insn_vax): Use ".word 0x0012 # Entry mask: r1 r2 >" instead
> > of just "Entry mask: < r1 ... >"
>
> Approved and applied. Although to be fair I think that you ought to
> have credited Kenn Humborg in the ChangeLog entry as well.
You're probably right, I'll do that subsequently if it happens again.
Now I'll go on and look for the next things to fix...
MfG, JBG
--
AWEK microdata GmbH -- Am Wellbach 4 -- 33609 Bielefeld