This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
PATCH: fix reference to symbol binding attributes
- From: Jim Blandy <jimb at redhat dot com>
- To: Nick Clifton <nickc at redhat dot com>, Richard dot Earnshaw at arm dot com
- Cc: binutils at sources dot redhat dot com
- Date: 23 Mar 2005 10:53:07 -0500
- Subject: PATCH: fix reference to symbol binding attributes
I've committed the following as obvious. The cast in ELF32_ST_BIND
hid the pointer-to-integer conversion, until I tried building it on an
AMD64, where pointers and unsigned ints are not the same size, and GCC
produced a warning.
2005-03-23 Jim Blandy <jimb@redhat.com>
* config/tc-arm.c (arm_adjust_symtab): Fetch elf_sym's binding
attributes properly.
Index: gas/config/tc-arm.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-arm.c,v
retrieving revision 1.196
diff -c -p -r1.196 tc-arm.c
*** gas/config/tc-arm.c 16 Mar 2005 17:27:16 -0000 1.196
--- gas/config/tc-arm.c 23 Mar 2005 15:42:06 -0000
*************** arm_adjust_symtab (void)
*** 13703,13709 ****
elf_symbol_type * elf_sym;
elf_sym = elf_symbol (symbol_get_bfdsym (sym));
! bind = ELF_ST_BIND (elf_sym);
/* If it's a .thumb_func, declare it as so,
otherwise tag label as .code 16. */
--- 13703,13709 ----
elf_symbol_type * elf_sym;
elf_sym = elf_symbol (symbol_get_bfdsym (sym));
! bind = ELF_ST_BIND (elf_sym->internal_elf_sym.st_info);
/* If it's a .thumb_func, declare it as so,
otherwise tag label as .code 16. */