This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR 813 (was Re: objdump --syms -j .text )


Hi Ramana,

Tested with i386-linux native . No extra failures. Ok to commit ?

Almost - the patch would not work if the dumping of special symbols was enabled (--special-syms) as well. So I have applied the following variation of your patch instead.


Daniel - would you like this patch in the 2.16 branch ?

Cheers
  Nick

Index: binutils/objdump.c
===================================================================
RCS file: /cvs/src/src/binutils/objdump.c,v
retrieving revision 1.102
retrieving revision 1.104
diff -c -3 -p -r1.102 -r1.104
*** binutils/objdump.c	18 Mar 2005 16:28:13 -0000	1.102
--- binutils/objdump.c	4 Apr 2005 10:32:28 -0000	1.104
*************** dump_symbols (bfd *abfd ATTRIBUTE_UNUSED
*** 2345,2352 ****
  	printf (_("could not determine the type of symbol number %ld\n"),
  		count);

!       else if (dump_special_syms
! 	       || !bfd_is_target_special_symbol (cur_bfd, *current))
  	{
  	  const char *name = (*current)->name;

--- 2345,2353 ----
  	printf (_("could not determine the type of symbol number %ld\n"),
  		count);

!       else if (process_section_p ((* current)->section)
! 	       && (dump_special_syms
! 		   || !bfd_is_target_special_symbol (cur_bfd, *current)))
  	{
  	  const char *name = (*current)->name;


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]