This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
fix broken Xtensa property tables
- From: Bob Wilson <bwilson at tensilica dot com>
- To: binutils at sources dot redhat dot com
- Date: Fri, 08 Apr 2005 10:33:10 -0700
- Subject: fix broken Xtensa property tables
- Organization: Tensilica, Inc.
Xtensa object files include "property tables" to provide extra information about
the contents of other sections. This patch disables the creation of property
tables for merged string sections. The problem is that if a string (or other
data object) is merged, any property table entry associated with that object is
left hanging around, and this can lead to invalid property tables. It's
unlikely that property tables will be needed for merged sections, anyway, since
they are primarily used for link-time relaxation of sections containing code.
Tested with an xtensa-elf target, and committed on the mainline and 2.16 branch.
2005-04-08 Bob Wilson <bob.wilson@acm.org>
* config/tc-xtensa.c (xtensa_create_xproperty_segments): Skip
SEC_MERGE sections.
Index: config/tc-xtensa.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-xtensa.c,v
retrieving revision 1.29
diff -u -p -r1.29 tc-xtensa.c
--- config/tc-xtensa.c 5 Apr 2005 23:37:34 -0000 1.29
+++ config/tc-xtensa.c 8 Apr 2005 17:24:18 -0000
@@ -10393,9 +10393,9 @@ xtensa_create_xproperty_segments (frag_f
flagword flags;
flags = bfd_get_section_flags (stdoutput, sec);
- if (flags & SEC_DEBUGGING)
- continue;
- if (!(flags & SEC_ALLOC))
+ if ((flags & SEC_DEBUGGING)
+ || !(flags & SEC_ALLOC)
+ || (flags & SEC_MERGE))
continue;
if (section_has_xproperty (sec, flag_fn))