This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Remove parameter names from libiberty.h
- From: Ian Lance Taylor <ian at airs dot com>
- To: "Dave Korn" <dave dot korn at artimi dot com>
- Cc: "'H. J. Lu'" <hjl at lucon dot org>, "'Andrew Pinski'" <pinskia at physics dot uc dot edu>, "'Paul Schlie'" <schlie at comcast dot net>, "'Kaveh R. Ghazi'" <ghazi at caip dot rutgers dot edu>, <binutils at sources dot redhat dot com>, <gcc-patches at gcc dot gnu dot org>, <amodra at bigpond dot net dot au>, <dj at redhat dot com>
- Date: 14 Apr 2005 16:58:33 -0400
- Subject: Re: Remove parameter names from libiberty.h
- References: <SERRANOJIc0y82gv5Gm00000163@SERRANO.CAM.ARTIMI.COM>
"Dave Korn" <dave.korn@artimi.com> writes:
> My two cents is that it's asking for trouble to #define an all-lower case
> word, particularly an extremely common one such as 'mode'. I had a quick
> grep but couldn't figure out where it's coming from. I guess that sort of
> thing is vaguely-ok-if-innately-fragile if it's being defined by the
> m88k-dis source file, but if there's a public header in either binutils or
> libiberty that's doing it, I'd think it ought to change.
It was coming from include/opcode/m88k.h, and it's already been fixed
there by Paul Brook.
Still, I don't think we should use parameter names for well understood
functions. There is no ideal policy here, but omitting unnecessary
parameter names seems to me to be wise regardless.
Ian