This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] i386 vxworks shared libraries - second try


On Fri, Apr 29, 2005 at 12:43:51AM +0100, Paul Brook wrote:
> Attached is a revised patch for i386 vxworks shared library support. The 

OK.  Except

+	     createing a definition in the output file but it does not come
+	     from any of out normal (.o) files. ie. a PLT stub.

creating, our

+	    {
+	      memcpy (htab->splt->contents,
+		      elf_i386_pic_plt0_entry, PLT_ENTRY_SIZE);
+	      memset (htab->splt->contents + 12, htab->plt0_pad_byte, 4);
+	    }

I'd prefer if you change the size of elf_i386_pic_plt0_entry to 12 bytes
and not use hardcoded numbers here.  The same goes for
elf_i386_plt0_entry.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]