This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Another HP-UX IA64 Build patch


Here is the second of my IA64 HP-UX build patches.  This one involves
the declaration of basename() in include/libiberty.h.  What do people
think about using the prototype version whenever we are compiling with
GCC?

I did that rather than checking for HP-UX because some HP-UX systems
(old PA ones) cannot handle the prototype but it seems like GCC should
always be able to deal with it and it is when using GCC that "-Wall
-Werror" will be set so I thought it might be better to check for GCC
rather than HP-UX.  Does this seem reasonable to people?  Maybe we could
remove some of the OS checks if we checked for GCC instead.

Tested on IA64 HP-UX.

Steve Ellcey
sje@cup.hp.com

include/ChangeLog:

2005-05-05  Steve Ellcey  <sje@cup.hp.com>

	libiberty.h: Use prototype for basename if compiling with GCC.


*** src.orig/include/libiberty.h	Thu May  5 10:04:07 2005
--- src/include/libiberty.h	Thu May  5 10:07:44 2005
*************** extern char **dupargv (char **) ATTRIBUT
*** 94,100 ****
     to find the declaration so provide a fully prototyped one.  If it
     is 1, we found it so don't provide any declaration at all.  */
  #if !HAVE_DECL_BASENAME
! #if defined (__GNU_LIBRARY__ ) || defined (__linux__) || defined (__FreeBSD__) || defined (__OpenBSD__) || defined(__NetBSD__) || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) || defined (HAVE_DECL_BASENAME)
  extern char *basename (const char *);
  #else
  extern char *basename ();
--- 94,100 ----
     to find the declaration so provide a fully prototyped one.  If it
     is 1, we found it so don't provide any declaration at all.  */
  #if !HAVE_DECL_BASENAME
! #if defined (__GNU_LIBRARY__ ) || defined (__GNUC__) || defined (__linux__) || defined (__FreeBSD__) || defined (__OpenBSD__) || defined(__NetBSD__) || defined (__CYGWIN__) || defined (__CYGWIN32__) || defined (__MINGW32__) || defined (HAVE_DECL_BASENAME)
  extern char *basename (const char *);
  #else
  extern char *basename ();


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]