This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Another HP-UX IA64 Build patch
- From: James E Wilson <wilson at specifixinc dot com>
- To: Steve Ellcey <sje at cup dot hp dot com>
- Cc: drow at false dot org, binutils at sources dot redhat dot com
- Date: Thu, 05 May 2005 11:10:30 -0700
- Subject: Re: Another HP-UX IA64 Build patch
- References: <200505051751.KAA17543@hpsje.cup.hp.com>
On Thu, 2005-05-05 at 10:51, Steve Ellcey wrote:
> I see it doesn't have the const modifier that libiberty has. I didn't
> get a warning or error presumbably because the build didn't include
> libgen.h.
This is a libiberty bug. Try "man basename" on a linux system, and it
will tell you that there are two versions of basename. The posix one
which takes a char * argument, and a glibc _GNU_SOURCE one which takes a
const char * argument. So this probably should be something like
#if defined(_GNU_SOURCE)
extern char *basename (const char *);
#elif defined...
extern char *basename (char *);
#else
extern char *basename ();
#endif
But it appears that nobody is including libgen.h anywhere, or we would
have caught this before.
For now, I think just adding __hpux__ to the list is fine, and we can
worry about the wrong prototype later, when and if it causes a problem.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com