This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR 834: IA64: Change br to brl for "far" brancheswhen possible


>>> Richard Henderson <rth@redhat.com> 16.05.05 19:43:45 >>>
>On Fri, May 13, 2005 at 09:19:54AM -0700, H. J. Lu wrote:
>> 	* elfxx-ia64.c (elfNN_ia64_relax_br): New.
>> 	(elfNN_ia64_relax_brl): Use it.
>
>This is ok, but I think you really shouldn't keep the nop predicate.
>You claimed you didn't want to change the user's code; what do you
>think you're doing here?!?  Both stances make no sense.

I guess the most reasonable thing to do here is to keep the predicate if the slot wasn't modified (i.e. was a nop before), but to strip it if the branch was actually moved out of that slot (and with it the predicate).

Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]