This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64: ensure unwind records' t coordinate gets set
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Tue, 24 May 2005 12:15:42 -0700
- Subject: Re: [PATCH] ia64: ensure unwind records' t coordinate gets set
- References: <s2919ab6.071@emea1-mh.id2.novell.com>
On Mon, 2005-05-23 at 00:56, Jan Beulich wrote:
> * config/tc-ia64.c (emit_one_bundle): Check all in-use slots for
> first with non-NULL unwind_record.
This one took a little thought, as you didn't mention what exactly was
wrong. The problem would be that if the next slot has no unwind record,
and some following slot does, then end_ptr is NULL, and we accidentally
initialize all unwind records, instead of those just belonging to the
current instruction. So we have to search for the next insn with unwind
info to set end_ptr.
This code fragment occurs twice, and the second one is still wrong.
That one is harmless though, since we don't remove unwind records from
the list, and hence we just end up initializing them multiple times.
For consistency, we should either fix this one also, or else add a
comment explaining why it is OK for it to be wrong. The existing
comment is actually wrong here, which adds to the possible confusion.
Otherwise, this is OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com