This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: MIPS, strip --only-keep-debug & an infinite loop


> On Wed, 18 May 2005, Maciej W. Rozycki wrote:
>  Well, I've had a look at the patch and I found out just returning a
> failure is inadequate for these functions.  For
> _bfd_mips_elf_section_processing() it's simply ignored.  For
> _bfd_mips_elf_section_from_shdr() it leads to such a damaged object being
> completely rejected, which prevents doing `objdump' or fixing it with
> another run of `strip --only-keep-debug' and is probably an overkill.  In
> neither case any useful diagnostics is available.  Therefore I've
> rewritten these changes to provide some diagnostics and attempt to
> continue anyway.
>
>  For _bfd_mips_elf_fake_sections() I agree appropriate handling of all
> special sections is desirable.
>
>  This has been checked not to cause any regressions in the test suite run
> for mipsel-linux-gnu natively.
>
> 2005-05-23  Mark Kettenis  <kettenis@gnu.org>
> 	    Maciej W. Rozycki  <macro@linux-mips.org>
>
> 	* elfxx-mips.c (_bfd_mips_elf_section_processing): Warn and
> 	stop processing of options if one of invalid size is
> 	encountered.
>         (_bfd_mips_elf_section_from_shdr): Likewise.
>         (_bfd_mips_elf_fake_sections): Reset the type of empty special
> 	sections.
>
>  OK to apply?  Since it fixes a fatal problem, I'm asking for permission
> for 2.16.1, too.

This looks fine to me.  Unfortunately I won't have the opportunity to test
this for a few weeks.  But I'm pretty confident it'll work.

Mark


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]