This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS/ld: Calculate DT_RELSZ correctly.


On Sat, May 28, 2005 at 02:42:53PM +0200, Thiemo Seufer wrote:
> David Daney wrote:
> > As outlined in this thread:
> > 
> > http://sourceware.org/ml/binutils/2005-05/msg00624.html
> > 
> > The 2.16 ld cannot correctly link the libgcj component of gcc 4.0.0.
> > 
> > The problem is that DT_RELSZ was being calculated before all of the 
> > relocations had been added to the dynamic relocations section.  This 
> > resulted in a value of DT_RELSZ that was too small.  The result was that 
> >  the runtime loader did not do all the relocations that were needed.
> > 
> > 
> > 2005-05-23  David Daney  <ddaney@avtrex.com>
> > 
> >         * elfxx-mips.c (_bfd_mips_elf_finish_dynamic_sections):  Move
> >         calculation of DT_RELSZ to occur after all dynamic relocations
> >         are created.
> > 
> > 
> > Tested on the CVS HEAD mipsel-linux cross running on i686-pc-linux-gnu 
> > with make -k check showing regressions.
> > 
> > O.K. to commit?  Should this go on the 2.16 branch as well?
> 
> Ok.

And 2.16.  I don't think David has write access; I'll take care of it.

-- 
Daniel Jacobowitz
CodeSourcery, LLC


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]